[Webkit-unassigned] [Bug 10096] Bring linux port uptodate

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Tue Jul 25 08:35:27 PDT 2006


darin at apple.com changed:

           What    |Removed                     |Added
   Attachment #9666|review?                     |review-
               Flag|                            |

------- Comment #2 from darin at apple.com  2006-07-25 08:35 PDT -------
(From update of attachment 9666)
I don't understand why we're patching the $Id parts. It's possible we need to
set the subversion flags that prevent is from modifying $Id sequences.

The change in kjs_html.h looks wrong to me. Could you explain that? It's
formatted wrong and just says FIXME. I don't want something like that in the
tree without an explanation.

The change to HTMLOptionsCollection doesn't look right, and before I'd land it
I'd need to see more explanation of why it's changed.

Need a ChangeLog.

As I've said in the past, if you make a smaller patch that doesn't try to do
everything at once, and leave out the more complex or controversial bits, you
can get most of this in, then we can discuss the part that's interesting

+    FrameGdk(Page*,Element*);

Formatting wrong, needs a space after the comma.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list