[Webkit-unassigned] [Bug 10094] Japanese characters improperly rendering in TOT

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10094


Graham.Dennis at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9667|                            |review?
               Flag|                            |




------- Comment #3 from Graham.Dennis at gmail.com  2006-07-24 23:50 PDT -------
Created an attachment (id=9667)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=9667&action=view)
patch

This bug only occurs when the first character of a text run is a decomposed
Japanese hiragana or katakana character with voice marks. The bug is caused
because WidthIterator::advance does not update the m_currentCharacter variable
while iterating, and then the call to WidthIterator::normalizeVoicingMarks
normalises the character starting at m_currentCharacter instead of starting at
currentCharacter. As a result, if the first character of a text run requires
normalising, all subsequent characters in the run will be displayed as being
identical to the first character (as m_currentCharacter will be 0).

This patch fixes the bug by turning the currentCharacter variable into an
argument to normalizeVoicingMarks.

A testcase has been included in the patch, however it must be run as a pixel
test for the test to actually check that the bug has been fixed.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.