[Webkit-unassigned] [Bug 8587] REGRESSION: {display:list-item} items outside an ol or ul element don't number correctly

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Sun Jul 23 08:19:38 PDT 2006


darin at apple.com changed:

           What    |Removed                     |Added
   Attachment #9626|review?                     |review+
               Flag|                            |

------- Comment #23 from darin at apple.com  2006-07-23 08:19 PDT -------
(From update of attachment 9626)
This is great as-is, so r=me.

Should have a period at the end of the comment to match the other comments in
the function.

It's a tiny bit inelegant to do traverseNextNode() inside that "if (otherList)"
case, because we end up doing traversePreviousNode() right after that, which
reverses it. However, I don't see a way to restructure the loop to avoid this
without making it more complicated and harder to read. The comment doesn't make
it entirely clear that the traverseNextNode is right simply because of the
traversePreviousNode coming up.

If I was writing the enclosingList function I'd make a local variable called
parent, since node->parentNode() is used twice. But that might just be a habit
of mine -- not really sure it's good programming style.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list