[Webkit-unassigned] [Bug 8272] Use of window.open & window.close can cause crash

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=8272


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9571|review?                     |review+
               Flag|                            |




------- Comment #9 from darin at apple.com  2006-07-19 22:50 PDT -------
(From update of attachment 9571)
I like this one a lot better.

I prefer a slightly different style for the current event constructor.
Something like:

    private:
        enum CurrentEventType { CurrentEvent };
        PlatformMouseEvent(CurrentEventType);

    public:
        static PlatformMouseEvent currentEvent();

and then:

    PlatformMouseEvent event = PlatformMouseEvent::currentEvent();

What you've done is quite similar, and pretty good, but I think mine is
slightly better.

r=me (if you decide not to do it my way; seems good to go as-is)


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.