[Webkit-unassigned] [Bug 10015] New: objects with TYPE="application/pdf" only use internal PDF image, don't use PDf plugins

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Wed Jul 19 13:51:50 PDT 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=10015

           Summary: objects with TYPE="application/pdf" only use internal
                    PDF image, don't use PDf plugins
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
               URL: http://acroeng.adobe.com/bugzilla/pdfbug.html
        OS/Version: Mac OS X 10.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: PDF
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: rsherry at adobe.com
                CC: rsherry at adobe.com


If you have an object with the property TYPE="application/pdf" and data that's
a PDF file, it will image the PDF file using the native NSImage stuff.  If you
remove the TYPE property, it will invoke a plug-in that handles PDF.

This happens even if you set the "OmitWebKitPDFSupport" preference.

See the URL.  The top square has the TYPE and you see it's blank; if you have
Adobe Reader installed the bottom square tries to load it.  Note that since
Adobe Reader 7 doesn't support embedded objects on the mac you will get an
error -- but there is no way that WebKit can account (or not) for that fact,
and it should try to load the plug-in if it can.

The problem is twofold:
(1) when the "type" token is read in, HTMLObjectEelement::isImageType() is
called to see if it's an image type... first, the plug-ins should be polled to
see if they are asking to handle this type.

(2) HTMLObjectEelement::isImageType() is returning true for "applicaotin/pdf"
because it returns true for all the types that NSImage can handle, but it never
checks the boolean preference "WebKitOmitPDFSupport" (WebKit checks it in some
places but WebCore does not); so "application/pdf" is considered an internal
image type and later -- when the check for plug-ins would normally happen for
unsupported types -- the plug-ins are never polled.  If that boolean preference
is set, the HTMLElement image types should specifically remove
"application/pdf" from the list (as WebKit does).

Either one of the above changes would fix this, but I believe that both changes
should be made.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list