[Webkit-unassigned] [Bug 9955] Colors scaled from [0, 1] range to [0, 255] incorrectly

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=9955


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9490|review?                     |review+
               Flag|                            |




------- Comment #2 from darin at apple.com  2006-07-16 07:53 PDT -------
(From update of attachment 9490)
Looks good.

+    float alpha = static_cast<float>(a) / 255.0f;

The cast above seems unneeded.

+                c.setRGB(238, 238, 238); // FIXME: if this is a constant it
should be specified as one.

I agree that would be nice to fix, but I don't think the FIXME adds much.

+    const double scaleFactor = nextafter(256.0, +0.0);

I think the use of + here on +0.0 is a bit queer. We could have + in front of
all our floating point constants but we don't.

Looks good, those are minor quibbles. r=me


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.