[Webkit-unassigned] [Bug 9742] REGRESSION: WebKit hangs when loading <http://www.vtbook.com>

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=9742


ggaren at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9429|review+                     |review-
               Flag|                            |




------- Comment #9 from ggaren at apple.com  2006-07-13 09:21 PDT -------
(From update of attachment 9429)
Great catch!

Two objections:

1. JavaScript layout tests should be written as pure JavaScript, and the HTML
to run them in DumpRenderTree generated by the
/WebKitTools/Scripts/make-js-test-wrappers script. You can see example .js
files in LayoutTests/fast/js/resources. The reason for this is that we want to
be able to run these tests outside of the browser, too.

2. It looks like the other get functions, like getNumber, have the same issue.
It would be best to change them too.

Note to commiter: We'll need to performance test the final patch before
landing, since it may change the inlining behavior of some hot functions.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.