[Webkit-unassigned] [Bug 9738] Unqualified :hover selector ignored in strict parsing mode

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=9738





------- Comment #5 from mjs at apple.com  2006-07-10 01:33 PDT -------
Conceptually this is a good fix. However:

+    // intended to apply the rules only to links.
+    bool onlyHoverActive = !strictParsing && (!sel->hasTag() &&
+                                              (sel->match ==
CSSSelector::PseudoClass &&
+                                                (sel->pseudoType() ==
CSSSelector::PseudoHover ||
+                                                 sel->pseudoType() ==
CSSSelector::PseudoActive)));


This makes "onlyHoverActive" a poor variable name now, since it no longer
represents just the fact tha the style consists of only hover and active
states.

I think it would be better to change the point of use instead, in terms of
clarity:

    // disallow *:hover, *:active, and *:hover:active except for links
    if (onlyHoverActive && subject) {

Otherwise the variable name should be changed to something like
shouldTreatAsQuirkyHoverActiveRule or something like that.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.