[Webkit-unassigned] [Bug 9179] Implement select.options.add() method

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Sun Jul 9 22:26:47 PDT 2006


ddkilzer at kilzer.net changed:

           What    |Removed                     |Added
Attachment #9174 is|0                           |1
           obsolete|                            |
   Attachment #9325|                            |review?
               Flag|                            |

------- Comment #20 from ddkilzer at kilzer.net  2006-07-09 22:26 PDT -------
Created an attachment (id=9325)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=9325&action=view)
Patch v3

Changes since Patch v2:

- Added more test cases specifically targeting -Infinity, NaN and +Infinity in
fast/dom/select-selectedIndex-multiple.html and
- Made sure fast/dom/select-selectedIndex.html was kept in sync with test cases
from select-selectedIndex-multiple.html.
- Overloaded KJS::JSValue::toInt32() to take a boolean 'Ok' argument to flag
when zero is returned for a float with a value of +-Infinity or NaN.
- Setting the options.length to a negative value now throws an exception. 
(This mimics MSIE 6, but differs from Firefox 1.5.0.x.)
- Passing anything other than an option element to options.add() causes an
exception to be thrown for all cases now (including +-Infinity and NaN, which
were being valued to zero before; this is where the new toInt32() method is
used to trap these values as errors).
- Changed overloaded function feature in CodeGeneratorJS.pm to use "argCount <"
instead of "argCount ==" comparison.
- Changed CanFailTypeConversion() in CodeGeneratorJS.pm to return true for
"unsigned long" and "long" types.  (They now use the new toInt32() overloaded
- Changed JSValueToNative() in CodeGeneratorJS.pm to use new toInt32()
overloaded method.

All layout tests still pass with these changes.  Will upload Firefox
and MSIE 6 test results next.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list