[Webkit-unassigned] [Bug 8251] netscape.product incorrect in WebKit.app on Intel Macs

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=8251


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9213|review?                     |review-
               Flag|                            |




------- Comment #4 from darin at apple.com  2006-07-08 06:28 PDT -------
(From update of attachment 9213)
Sorry to be difficult, but there is at least one problem here. If the macro is
going to be in Platform.h, then the prefix should not be WEBCORE_ but rather
WTF_. But also, if it's going to be in Platform.h it has to be the whole macro,
not just the PPC part, with the WIN32 bit etc.

I think we should go back to something more like the original patch that's in
kjs_navigator.cpp, but not with something that starts with an underscore. I
think that you should use PLATFORM(PPC) instead of a custom ifdef. And I think
that all the platforms should use the macro instead of having ifdefs in the
Platform case in the casae statement.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.