[Webkit-unassigned] [Bug 9717] Replace IDL ConvertUndefinedToTrue parameter attribute with Optional attribute

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=9717





------- Comment #6 from ddkilzer at kilzer.net  2006-07-04 04:47 PDT -------
(In reply to comment #4)
> Yes, I think you need <=, although I would vote for < as being a little
> clearer. That's something to change in your patch for bug 9179, right?

Yes.  I'll go make that change in Bug 9179.

> With one exception, I think this patch is ready to land once the patch for bug
> 9179 is reviewed. The exception is that you do need a testcase, even if there
> is no behavior change. We have had many bugs with IDL changes accidentally
> producing behavior changes. You need to confirm that the optional parameter
> calling convention actually works. If an existing test already covers that,
> it's fine to name that test in the ChangeLog instead of duplicating the effort,
> but I don't think it's OK to land this change without any test.

Test cases for DOMWindow.getMatchedCSSRules() are (the last two rely on the
overloaded behavior):

LayoutTests/fast/dom/defaultView.html
LayoutTests/fast/inspector/matchedrules.html
LayoutTests/fast/inspector/style.html

Test cases for Element.scrollIntoView() are:

WebCore/manual-tests/scrollIntoView-horizontal.html
WebCore/manual-tests/scrollIntoView-vertical.html

Note that there are no test cases for Element.scrollIntoViewIfNeeded(),
although the change to the code is identical for both scrollIntoView() and
scrollIntoViewIfNeeded().

The manual tests above passed, e.g., they did the same thing in Safari 2.0.4
(419.3) on Mac OS X 10.4.7 (8J135/PowerPC) as they did with a locally-built
WebKit r15147 with patches for Bug 9179 and this patch applied; and they passed
per instructions on the manual tests.

All of the layout tests passed as well.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.