[Webkit-unassigned] [Bug 9670] REGRESSION: RTL white-space:pre-wrap text is offset to the right

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Tue Jul 4 01:22:04 PDT 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=9670


mjs at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9119|review?                     |review-
               Flag|                            |




------- Comment #7 from mjs at apple.com  2006-07-04 01:22 PDT -------
(From update of attachment 9119)
I agree with darin's comment about offsetForAlignRight.

I think if there is extra space around in an existing bitfield, it is ok to use
one of those bits. However, this should be justified with some kind of
measurement of the perf impact. I think since m_reversed is checked first, then
at least the LTR case should be optimized already, but perhaps in many RTL
cases the other calculations can be skipped.

r-  so you can decide what to do here but I think the patch is good to go
either way (assuming I am right that LTR should normally be unaffected).


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list