[Webkit-unassigned] [Bug 9651] MSVCRT time functions are too strict
bugzilla-daemon at opendarwin.org
bugzilla-daemon at opendarwin.org
Mon Jul 3 18:13:01 PDT 2006
http://bugzilla.opendarwin.org/show_bug.cgi?id=9651
darin at apple.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #9093|review? |review-
Flag| |
------- Comment #2 from darin at apple.com 2006-07-03 18:13 PDT -------
(From update of attachment 9093)
This seems like too much platform-specific code to put into this file.
I suggest putting it somewhere in WTF instead, maybe a file named
<wtf/DateExtras.h>. Maybe we can move the Mac-specific data locale code there
too.
+ //if (secs < time_tMin || secs > time_tMax) {
We don't check in commented-out code.
While the reformatting is fine, ideally I'd like to see that in a separate
patch rather than in the same patch as a substantive change to the file. Maybe
we can get that in first.
I think it's not so great to have a KJS::tm on the Windows platform and a
global tm on all the others. Maybe we can use a typedef instead?
--
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list