[Webkit-unassigned] [Bug 9678] fmod function of MS CRT returns NaN for x / Inf

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Mon Jul 3 18:05:49 PDT 2006


darin at apple.com changed:

           What    |Removed                     |Added
   Attachment #9128|review?                     |review-
               Flag|                            |

------- Comment #2 from darin at apple.com  2006-07-03 18:05 PDT -------
(From update of attachment 9128)
I'd like to see this workaround in MathExtras.h rather than inline in the
JavaScript-specific files. We just need a name for the fmod with the
workaround, and then we can use that. It can be an inline that expands to a
call to fmod on platforms other than Win32.

Also, we do COMPILER(MSVC) rather than _MSC_VER for these kinds of ifdefs.

I don't think we need PLATFORM(WIN) at all -- probably COMPILER(MSVC) is the
whole check needed.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list