[Webkit-unassigned] [Bug 9717] Replace IDL ConvertUndefinedToTrue parameter attribute with Optional attribute

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Mon Jul 3 14:48:19 PDT 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=9717





------- Comment #4 from ggaren at apple.com  2006-07-03 14:48 PDT -------
Yes, I think you need <=, although I would vote for < as being a little
clearer. That's something to change in your patch for bug 9179, right?

With one exception, I think this patch is ready to land once the patch for bug
9179 is reviewed. The exception is that you do need a testcase, even if there
is no behavior change. We have had many bugs with IDL changes accidentally
producing behavior changes. You need to confirm that the optional parameter
calling convention actually works. If an existing test already covers that,
it's fine to name that test in the ChangeLog instead of duplicating the effort,
but I don't think it's OK to land this change without any test.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list