[Webkit-unassigned] [Bug 6838] Incomplete repaint of collapsed table borders

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=6838


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5990|review?                     |review-
               Flag|                            |




------- Comment #3 from darin at apple.com  2006-01-27 08:50 -------
(From update of attachment 5990)
I'm disappointed we have to add so much new code, but it looks pretty good to
me. Is there any way to share more of this? Should we invent a structure that
holds the four separate widths so it can be a single function instead of 4?

I believe you forgot to mark the functions virtual.

+    const BorderValue sb = style()->borderRight();

We normally don't mark local variables const.

+    return int(borderWidth / 2.0 + 0.5);

Can be done more efficiently by doing (borderWidth + 1) / 2. This idiom comes
up multiple times.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.