[Webkit-unassigned] [Bug 6852] New: sometimes have to click twice to jump to top, on href="" (WebCore/manual-tests/linkjump-1.html)

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=6852

           Summary: sometimes have to click twice to jump to top, on href=""
                    (WebCore/manual-tests/linkjump-1.html)
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.0
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HTML DOM
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: vicki at apple.com


This bug is also in Radar as <rdar://4304213>

Open WebCore/manual-tests/linkjump-1.html.  Click the numbered links to scroll
through the document.  The third link, "3. click to top" should take you to the
top of the page the first time you click it.  

However, nothing happens the first time I click this link.  I have to click
this link a second time to get the page to scroll back to the top.  Works in
Firefox.



<GMT19-Oct-2005 19:41:17GMT> Vicki Murley:
The link that is not returning to the top when it should is <a href="">3. click
to  top</a>

-------------------------------------------

<GMT17-Oct-2005 21:31:34GMT> Vicki Murley:
This is not a regression, it's like this in Safari 2.0 too.

<GMT19-Oct-2005 19:21:13GMT> Vicki Murley:
I have a fix for this in my tree.

<GMT19-Oct-2005 19:41:17GMT> Vicki Murley:
Could you review the attached patch?  The fix here is just to remove the check
for m_url.hasRef().  

m_url.hasRef() returns false for "" because queryEndPos is equal to
fragmentEndPos.  We don't need this check, b/c encodedHtmlRef() handles this
case by returning an empty QString when queryEndPos and fragmentEndPos are
equal.  And that is what we want, b/c the subsequent call to 
gotoAnchor(Qstring) correctly handles this case.

<GMT21-Oct-2005 23:10:49GMT> Vicki Murley:
John reviewed this.

<GMT22-Oct-2005 17:57:56GMT> John Sullivan:
Hyatt rolled out the change because he said it made every page jump to the end
when loaded.

<GMT13-Dec-2005 18:49:52GMT> Alice Liu:
Safari BRB Reviewed


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.