[Webkit-unassigned] [Bug 6403] Windows patch: KJS_EXPORT for building DLLs

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=6403


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5726|review?                     |review-
               Flag|                            |




------- Comment #9 from darin at apple.com  2006-01-22 12:04 -------
(From update of attachment 5726)
I don't think we want a FIXME in config.h for the possible future use of
KJS_EXPORT for GCC visibility control; lets remove that for now.

The JSValue stuff should not be in an #if !WIN32 ifdef, because we do want
those undefined copy constructor and assignment operators on Windows. Better
would be to actually define them in value.cpp, but only when we are building a
DLL on Windows. I don't think that WIN32 alone is good enough to indicate
"building a DLL". For example, I know we might want to build a static library
for Windows rather than a DLL, so we don't want ifdefs that assume "WIN32 ==
DLL".

Setting review- just because of the the value.h thing -- otherwise looks great,
and about ready to land.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.