[Webkit-unassigned] [Bug 3527] Allow Safari to open postscript files in browser windows as well

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=3527


ddkilzer at kilzer.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-                     |ddkilzer at kilzer.net
                   |unassigned at opendarwin.org   |
             Status|NEW                         |ASSIGNED
   Attachment #5835|                            |review?
               Flag|                            |




------- Comment #9 from ddkilzer at kilzer.net  2006-01-22 04:22 -------
Created an attachment (id=5835)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=5835&action=view)
Patch v1 (initial hack)

This patch is basically a first-pass hack at viewing of PostScript files work
in Safari.  Looking for feedback on the following:

- Class design.  I basically copied WebPDFRepresentation.h/m to
WebPostScriptRepresentation.h/m, changed the class names, and added code to the
finishedLoadingWithDataSource() method.  Is there a better way to do this? 
Should I create a base class for them?  Or combine them into a single class and
conditionalize the PS-to-PDF conversion (not very OO-design-worthy, though)?

- Am I doing anything stupid with the Core Graphics APIs or not releasing
references that I should in the PS-to-PDF code?  Specifically, am I using
"toll-free" casts?

- The CGDataConsumerCreateWithCFData() call was added in 10.4.  Is this an
issue (backward compatibility with 10.3)?

- Is there a better way to check the value of 'success'?


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.