[Webkit-unassigned] [Bug 6448] <text> does not support custom fills or strokes

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Sun Jan 22 00:28:31 PST 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=6448





------- Comment #4 from macdome at opendarwin.org  2006-01-22 00:28 -------
(From update of attachment 5823)
So a few comments.

+    virtual void render(KRenderingDeviceContext* context, const RenderPath*
renderPath, KCPaintTargetType type) const { }

these should be pure virtual ( = 0 ) instead.

Everything in WebCore is now in a single namespace.  No need to use khtml:: or
KDOM:: in new code.  Also KSVG should be replaced by WebCore in these files as
you edit them.

+            int width  = 2048;
+            int height = 2048; // FIXME???
+            IntSize size = IntSize(width, height);

needs to be replaced by some real text measurement code.

The QPainter p; and PaintInfo creation code inside RenderText should be
completely unecessary.  You should just be able to pass the exisiting
"paintInfo" variable into RenderBlock::paint()


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list