[Webkit-unassigned] [Bug 6553] KCanvas needs to be redesigned to fill & stroke at once

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Sun Jan 15 06:31:38 PST 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=6553


andersca at mac.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5694|review?                     |review-
               Flag|                            |




------- Additional Comments From andersca at mac.com  2006-01-15 06:31 -------
(From update of attachment 5694)
Patch looks great, a few minor comments though:

- for pointer types (such as RenderPath), the * should be next to the
identifier, not the type.
- The RenderPath parameter should really be const. This might require having to
modify other function declarations called by the different draw implementations


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list