[Webkit-unassigned] [Bug 6452] KIO::appendEscapingBadChars() doesn't know about %u-escaping.

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=6452


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5599|review?                     |review-
               Flag|                            |




------- Additional Comments From darin at apple.com  2006-01-10 15:08 -------
(From update of attachment 5599)
First, thanks for submitting this patch. It seems quite important to fix this
bug!

But I don't think this fix is correct.

I think we should either be escaping all % characters in the string or not
escaping any. It doesn't seem right to decide whether to escape the % character
based on whether it's followed by u201F (for example) or not.

If we shouldn't be escaping "%" characters in this case, then we need to change
KURL behavior, perhaps adding a parameter if we don't always want that
behavior.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.