[Webkit-unassigned] [Bug 6257] Throw errors on invalid expressions/support non-PCRE regexp (KJS merge)

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=6257





------- Additional Comments From maksim at kde.org  2006-01-09 15:21 -------
I can only respond partly, since I am leaving for a conference soon'ish,and I 
better finish packing 
 
1. libpcre plain doesn't support as many nested parentheses as mozilla, so I 
do think the expectation for the test needs to be adjusted --- the point is 
that it shouldn't crash, anyway 
 
4. This code doesn't only work with PCRE, but also (somewhat) with POSIX   
regexps, if PCRE is not available. In that case, you can not 0-check.   
   
3. As Darin said, the lexer approach seems wrong for constructed strings.  
e.g. 'b a'.search(new RegExp("\\u" + "0020")) in firefox returns 1.  
  
2. I can certainly do a 2-pass approach, though it'll likely take some  
restructuring to get it to not overly complicate the code, considering 2.5 
RegExp runtimes supported. 
 

-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.