[Webkit-unassigned] [Bug 5748] KCanvas needs to be redesigned to fill & stroke at once

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=5748


macdome at opendarwin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5555|                            |review-
               Flag|                            |




------- Additional Comments From macdome at opendarwin.org  2006-01-08 14:48 -------
(From update of attachment 5555)
Again, looks great.  A couple comments:

No need to check canvasStyle() or path() first, just have:
KRenderingPaintServer *fillPaintServer =
canvasStyle()->fillPaintServer(canvasStyle()->renderStyle(), this);
and then check if non-null, if non-null, setActiveClient(this) and draw()

overrideFillPaintServer overrideStrokePaintServer shoudl assume type IMAGE, and
shoudl ASSERT that the passed in paint server is of that type.	Also, I woudl
encourage you to land a // FIXME: right next to those functions describing how
they were going away.

Otherwise this looks great.

You had mentioned there was a laytou test regression wrt Images.  We'll wait to
land until that's fixed.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.