[Webkit-unassigned] [Bug 5353] DrawTest should subclass WebView instead of DrawView

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Sat Jan 7 23:32:39 PST 2006


macdome at opendarwin.org changed:

           What    |Removed                     |Added
   Attachment #5533|review?                     |review-
               Flag|                            |

------- Additional Comments From macdome at opendarwin.org  2006-01-07 23:32 -------
(From update of attachment 5533)
There are a number of things we'll need to fix before landing.

First of all, we don't generally commit commented out code, or logging/debug
code.  In this case, we'll have to make an exception (since bringing all of
DrawTest back and working in one pass is probably not reasonable).  However,
the large sections of code which you'd like to disable should use #if 0 instead
of // all other new commented code (like header files, etc.) should be removed.

It looks like your change to DrawTestDocument.nib is a noop.  I would just
remove it from this patch.

Try those couple changes and re-post.  Also, eventually we'll need to have you
post a ChangeLog as part of your patch (prepare-ChangeLog will do that for

Finally, any files you change should include your copyright.  Just use the same
format we do

Copyright (C) 2006 Nefaur Khandker <nefaurk at gmail.com>	All rights reserved.


Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list