[Webkit-unassigned] [Bug 5748] KCanvas needs to be redesigned to fill & stroke at once

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=5748


macdome at opendarwin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5516|review?                     |review-
               Flag|                            |




------- Additional Comments From macdome at opendarwin.org  2006-01-06 19:08 -------
(From update of attachment 5516)
We talked online.  Although this is a good patch, I think that it makes more
sense (in terms of process overhead) to go a bit further along the removal
process first.

I encoruaged Alexander to take the approache of just removing all the set*
methods on KCanvasRenderingStyle and making all of the get methods dynamically
compute/lookup, etc. all the necessary info.  That way none of the callers have
to change (more than they have in this patch), but KCanvasRenderingStyle
becomes a complete no-op and we can get rid of more of this uncessary code in
one fell swoop.

I also encoruaged alexander to make sure that he posts layout test changes, and
is sure to test with --leaks.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.