[Webkit-unassigned] [Bug 6253] KXMLCore::identifyExtract, KXMLCore::extractFirst not linking on Windows

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Mon Jan 2 20:32:26 PST 2006


------- Additional Comments From mjs at apple.com  2006-01-02 20:32 -------
Oops, I misunderstood the first patch at first. If these are specializations specific to the types, then yes it 
is better to have them in the .cpp files. I'm ok with that change now. However, an even better fix would be 
to use a template class for the extract function instead of a template function, since Visual Studio seems 
to deal with those better. 

For example look at the way HashFunctions and HashTranslators are done. Even though extractors are just 
a single function, they might still work better this way.

r=me for the original patch as an interim fix, but please consider doing it the class way.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list