[Webkit-unassigned] [Bug 6252] JavaScript 1.6 Array.lastIndexOf

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=6252


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6777|review?                     |review-
               Flag|                            |




------- Comment #7 from darin at apple.com  2006-02-28 20:36 PDT -------
(From update of attachment 6777)
This code looks like it won't work in a couple of ways:

    1) If 0 is passed it looks like it will search the entire array, but that's
not what the documentation seems to call for.

    2) The for loop seems to stop with index == 1, so it will miss index == 0.

In any case, we need a test case and change log to land a change like this.
Please add a test case that covers both of these issues and test the code
before putting it up for review again.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.