[Webkit-unassigned] [Bug 7152] REGRESSION: Select All does not highlight table if it's last in the document

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Mon Feb 20 14:00:19 PST 2006


------- Comment #10 from justin.garcia at apple.com  2006-02-20 14:00 PDT -------
(From update of attachment 6614)
+        while (endNode && endOffset != 0 &&
!offsetInCharacters(endNode->nodeType())) {
+            if (NodeImpl* child = startNode->childNode(endOffset)) {
+                endNode = child;
+                endOffset = 0;

Don't you want to use endNode instead of startNode here?

+        if (startNode && !isAtomicNode(startNode))
+            if (NodeImpl* child = startNode->childNode(startOffset)) {
+                startNode = child;
+                startOffset = 0;
+            }

This would only descend one level, why not continue descending until you hit an
atomic node, like you did to fix up the end position?

The descent that you did could leave you at a node that doesn't have a
renderer.  What you'd need to do is descend to an atomic position, create a
visible position with that, then pull out that VPs deepEquivalent and give that
to RenderCanvas::setSelection.

But I think that we should fix RenderCanvas::setSelection.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list