[Webkit-unassigned] [Bug 7363] REGRESSION (r12872): Repro crash when clicking the Quick Reply box in Gmail

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=7363


opendarwin.org at mitzpettel.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vicki at apple.com
           Keywords|NeedsReduction              |HasReduction
            Summary|REGRESSION: Repro crash when|REGRESSION (r12872): Repro
                   |clicking the Quick Reply box|crash when clicking the
                   |in Gmail                    |Quick Reply box in Gmail




------- Comment #2 from opendarwin.org at mitzpettel.com  2006-02-19 10:56 PDT -------
This is a regression from r12872 (the fix for <rdar://problem/4315673> and
<rdar://problem/4447009>). The crash happens when the element losing focus no
longer has a renderer. The fix may be as simple as adding a null check for r
right here in DocumentImpl::setFocusNode:

        // Dispatch a change event for text fields or textareas that have been
edited
        RenderObject *r =
static_cast<RenderObject*>(oldFocusNode.get()->renderer());
        if ((r->isTextArea() || r->isTextField()) && r->isEdited()) {
            oldFocusNode->dispatchHTMLEvent(changeEvent, true, false);
            r->setEdited(false);
        }

However I'm not sure about the implications of not dispatching the changeEvent
in this case.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.