[Webkit-unassigned] [Bug 6890] SVG - invalid polyline data causes hang

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Tue Feb 14 03:21:28 PST 2006


macdome at opendarwin.org changed:

           What    |Removed                     |Added
   Attachment #6464|review?                     |review-
               Flag|                            |

------- Comment #6 from macdome at opendarwin.org  2006-02-14 03:21 PDT -------
(From update of attachment 6464)
A couple comments:

1.  I think it's better to declare optr on its own line. (make the declaration
less confusing).
2.  I think optr deserves a better name.  Honestly, I think ptr deserves a
better name...  The code is hard enough to read as is... giving the variables
cryptic names only hurts :(
3.  While you're in there, you might as well remove the commented out
//std::cout lines.

Three little nits, if you were landing your own patches you could just fix them
as you landed, but since someone else has to land this, I think it's best to
get one more round of patches.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list