[Webkit-unassigned] [Bug 7158] New: WebKit needs generalized Undo mechanism for DOMNode manipulations

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=7158

           Summary: WebKit needs generalized Undo mechanism for DOMNode
                    manipulations
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: WebKit API
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: ttalbot at karelia.com


Via paste of DOMNode category method in #webkit channel,
http://paste.lisp.org/display/16627, consider the following lines of code from
that method:

  [[undoManager prepareWithInvocationTarget:[self parentNode]]
replaceChild:self :element];
  [[self parentNode] replaceChild:element :self];

Assume that self and element are valid DOMNodes. During Undo, retain is sent to
a released (zombie) object, halting program execution. Tests show that it's the
target [self parentNode] that is being prematurely released. (This makes sense
as NSUndoManager does not explicitly retain targets.)

It would be helpful if WebKit had a general strategy for undo'ing DOMNode
manipulations such as this via Cocoa that handled correctly retaining the Obj-C
DOMNode wrappers.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.