[Webkit-unassigned] [Bug 7069] New: visiting a bookmarked site that now has a site icon will not update bookmark's icon

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=7069

           Summary: visiting a bookmarked site that now has a site icon will
                    not update bookmark's icon
           Product: WebKit
           Version: 412
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P2
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: sullivan at apple.com


This is also in Radar as 3028061. That Radar is very old and has some tangents
in it, so I've just recreated the gist of it here rather than copy/pasting the
original text.

If you have a bookmark for a site, and visit the site, and then later visit the
site again after it has either changed its site icon or gotten a site icon for
the first time, the bookmark will not update to show the new site icon. This
happens because WebKit caches the old icon, or caches the fact that the site
did not have an icon, in order to avoid the performance hit of checking for the
favicon on every page load.

The icon database only remembers icons for sites that are in History or
bookmarks, so if you delete any bookmarks/history for a site, then quit and
relaunch Safari, Safari should pick up the correct site icon. But as long as
there's an old bookmark or history item for the site, Safari's outdated info
about the site icon will be preserved.

The workaround is to delete ~/Library/Safari/Icons/.

We could probably come up with some better scheme for this that still did not
require trying to load the icon on every page load. For instance, perhaps the
icon database could store a last-fetched date for the icon, and when that date
is a certain age (1 day? 1 week?) WebKit would attempt to fetch a fresh site
icon when the page/site is next visited.

This logic is all in WebIconDatabase.m.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.