[Webkit-unassigned] [Bug 6648] Safari strips-off namespace when using getAttribute()

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Fri Feb 3 19:40:20 PST 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=6648


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6231|review?                     |review-
               Flag|                            |




------- Comment #10 from darin at apple.com  2006-02-03 19:40 PDT -------
(From update of attachment 6231)
I don't understand this patch.

The getAttribute, setAttribute, and removeAttribute implementations all do the
same thing, calling through to get/set/removeAttributeNS with a namespace URI
of null.

How can it possibly be correct to change only setAttribute and not the other
two?

If you can answer that question, it seems OK to set this to review? again. By
the way, it's best to include the change log entry and the layout test case in
the patch.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list