[Webkit-unassigned] [Bug 5146] max-height/max-width not resizing images with correct aspect ratio

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Wed Feb 1 21:26:45 PST 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=5146


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6089|review+                     |review-
               Flag|                            |




------- Comment #10 from darin at apple.com  2006-02-01 21:26 PDT -------
(From update of attachment 6089)
I went to land this patch, and discovered that the test case
maxwidth-percent.html fails with the patch.

I debugged a bit and found that when computing the width,
RenderBox::calcReplacedWidthUsing(MaxWidth) calls containingBlockWidth() and
gets 0, so it returns intrinsicWidth, 100, instead of 50% of the containing
block's width. The reason containingBlockWidth() gets 0 is that usesLineWidth()
returns true.

It's possible this fix worked fine in the KDE tree but we need more work to get
it to do the right thing.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list