[Webkit-unassigned] [Bug 12023] svn-create-patch and friends should handle moved/copied files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 31 21:14:53 PST 2006


http://bugs.webkit.org/show_bug.cgi?id=12023





------- Comment #4 from ddkilzer at webkit.org  2006-12-31 21:14 PDT -------
After typing up Comment #3, I've almost convinced myself that I need another
way to add a hint to the patch to describe copied files.  This is what
svn-create-patch from Patch v2 will generate (from Bug 12036):

Index: JavaScriptCore/pcre/pcre_printint.src
===================================================================
--- JavaScriptCore/pcre/pcre_printint.c (revision 18482)
+++ JavaScriptCore/pcre/pcre_printint.src       (working copy)

Perhaps a better approach would be to add another set of parenthesis on the
"old" line describing the original source like this (will probably wrap
poorly):

Index: JavaScriptCore/pcre/pcre_printint.src
===================================================================
--- JavaScriptCore/pcre/pcre_printint.src (revision 18482)
(JavaScriptCore/pcre/pcre_printint.c at 18482)
+++ JavaScriptCore/pcre/pcre_printint.src       (working copy)

I need to do some testing, but that may be more acceptable to patch(1) than
changing the "old" line.

Comments?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list