[Webkit-unassigned] [Bug 12007] SVGColor::setRGBColor color creates/deletes many strings, slowing down parsing

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12007


macdome at opendarwin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12100|review?                     |review+
               Flag|                            |




------- Comment #5 from macdome at opendarwin.org  2006-12-29 12:45 PDT -------
(From update of attachment 12100)
Looks great.

It appears you didn't change any of the HTML Color parsing code paths, which is
good.

expectsValid needs to check the set value (make sure it set correctly).  And I
think you coulud add a few more valid tests (for leading/tailing spaces,
commas, etc.)

With a few more tests and the expectedValid fix, feel free to land!


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.