[Webkit-unassigned] [Bug 9454] CSS2: Language not inherited from parent element

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=9454


sam at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12107|review?                     |review-
               Flag|                            |




------- Comment #4 from sam at webkit.org  2006-12-29 12:04 PDT -------
(From update of attachment 12107)
Nice to see this finally getting ported over.  I think it would be appropriate
to add a comment/FIXME or two about the missing features (ie, no support for
HTTP content-language or xml:lang (though as you explained that has not been
defined)).  We also usually put the patch, the tests (and their expected
results) and the ChangeLogs together in one patch to be easily landed.  We have
a prepare-ChangeLog script to make the ChangeLog and svn-create-patch script to
create the patch.  


Only one semi-color required here.

+                Node *n = e->parent();;


I also have a few style nits.

We put the * on the otherside

+                Node *n = e->parent();;

Single line if statements don't get curly-braces.

+                    if (n->isElementNode()) {
+                        value =
static_cast<Element*>(n)->getAttribute(langAttr);
+                    }

r- for now.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.