[Webkit-unassigned] [Bug 12007] SVGColor::setRGBColor color creates/deletes many strings, slowing down parsing

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12007


macdome at opendarwin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12089|review?                     |review-
               Flag|                            |




------- Comment #3 from macdome at opendarwin.org  2006-12-28 17:46 PDT -------
(From update of attachment 12089)
The patch looks pretty good.

The test case is busted.  You never actually use "value".

I don't think you need to init RGBA32 to transparent (at least not outside the
parse function).

It's still unfortunate that we're creating new SVGPaints even for invalid
colors.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.