[Webkit-unassigned] [Bug 11588] offsetwidth gives different values in Firefox and Safari in certain tables

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=11588


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11968|review?                     |review-
               Flag|                            |




------- Comment #7 from darin at apple.com  2006-12-22 17:44 PDT -------
(From update of attachment 11968)
Looks pretty good to me.

I'd like to understand whether the case where numAuto == nEffCols is really a
special case, or if the general algorithm needs to be corrected.

This change needs a layout test and change log.

Has someone run the layout tests with this patch in place? does this affect the
results of any of the layout tests?

Formatting is not correct in this patch. For example, it uses tabs for
indentation, and this:

+ int w = available / nCols -- ;

should be formatted like this:

    int w = available / nCols--;

and this:

+ }else{

should be formatted like this:

    } else {

Because of these concerns, review-.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.