[Webkit-unassigned] [Bug 11346] _blank is assigned to Window name

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 22 06:49:36 PST 2006


http://bugs.webkit.org/show_bug.cgi?id=11346


ddkilzer at kilzer.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11964|                            |review-
               Flag|                            |




------- Comment #10 from ddkilzer at kilzer.net  2006-12-22 06:49 PDT -------
(From update of attachment 11964)
Thanks for the patch!  There are still some issues that need to be cleaned up,
though.

1. Please use WebKitTools/Scripts/prepare-ChangeLog to generate your own
ChangeLog entry, then use WebKitTools/Scripts/svn-create-patch to generate the
patch.  More info here: http://webkit.org/coding/contributing.html

2. No tabs are allowed in the source code.  Please use spaces instead.  More
info here:  http://webkit.org/coding/coding-style.html

3. A manual test in WebCore/manual-tests should be included with the patch per
Maciej in Comment #8.

Almost there!


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list