[Webkit-unassigned] [Bug 11899] New: framesets force full-view repaint unnecessarily

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=11899

           Summary: framesets force full-view repaint unnecessarily
           Product: WebKit
           Version: 420+ (nightly)
          Platform: PC
               URL: http://stein.cshl.org/WWW/CGI/examples/frameset.cgi
        OS/Version: Windows XP
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: occupant4 at gmail.com


Visit the sample URL, and click in the entry box to focus it.  As the cursor
flashes, repaints are issued.  However, because the entry box is within a
frameset, the repaint is applied to the full contents of the frameset rather
than just the entry box.

(You can check this by adding a printf() in WebFrame::paint() to print out
ps.rcPaint.  Compare that to what happens when you just navigate to the frame
with the entry box -
http://stein.cshl.org/WWW/CGI/examples/frameset.cgi/query).

This happens because on every call to FrameView::layout, the following code is
executed:
                if (body->hasTagName(framesetTag)) {
                    body->renderer()->setNeedsLayout(true);
This seems unnecessary and wrong.  I believe the correct fix is to remove the
call to setNeedsLayout.  I'll make sure that doesn't break the layout tests,
and submit a patch.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.