[Webkit-unassigned] [Bug 11824] CSSStyleSheet.title property is always null

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=11824





------- Comment #9 from rwlbuis at gmail.com  2006-12-14 14:30 PDT -------
Hi Darin,

(In reply to comment #8)
> (From update of attachment 11845 [edit])
> -    void childrenChanged(Node*);
> +    void childrenChanged(Element*);
> 
> This has the same overloading problem as the first patch; changing the type of
> the parameter prevents it from properly overriding the function in the base
> class.

Mitz and myself do not get what you mean here. childrenChanged(Element*) is not
virtual, so I don't see  how overriding is involved. I think there is enough
difference between the two functions for the compiler to distinguish them. I
can see the name may be confusing, would it help if we name it process() for
example? If you feel the problem is still there, can you explain it one more
time?

> The rest looks basically good. But what about SVG style elements?

I'll add a test in the morning for svg style elements. Will likely be a
separate svg test in svg/custom.
Cheers,

Rob.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.