[Webkit-unassigned] [Bug 11824] CSSStyleSheet.title property is always null

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=11824


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11840|review?                     |review-
               Flag|                            |




------- Comment #3 from darin at apple.com  2006-12-14 12:12 PDT -------
(From update of attachment 11840)
-    void childrenChanged(Node*);
+    void childrenChanged(Node*, const String& = String());

This is not a good change. Even though the declaration does not say so, this is
an override of the childrenChanged function from Node.

By changing the parameters this no longer overrides the Node function, so
callers that call the virtual function on Node won't call this function any
more. I think this subtle semantic change probably creates bugs.

To make this clearer, the virtual keyword should be added to these functions in
StyleElement.h. And we need to rethink how to do this -- I think it should be a
separate function rather than a new parameter to childrenChanged.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.