[Webkit-unassigned] [Bug 11625] Investigate possibility to share code between HTMLStyleElement and SVGStyleElement
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 7 16:05:44 PST 2006
http://bugs.webkit.org/show_bug.cgi?id=11625
darin at apple.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #11571|review? |review+
Flag| |
------- Comment #8 from darin at apple.com 2006-12-07 16:05 PDT -------
(From update of attachment 11571)
+ Element *e = static_cast<Element *>(n);
Should move the * next to Element.
+#include "Node.h"
+#include "Document.h"
No need to include both Document and Node, since Document is a Node.
+ String _type = type();
It's best to not use leading underscores in identifiers, since those are
reserved for the compiler and operating system.
+class MappedAttribute;
This is a forward declaration for a class not used in the file; please leave it
out.
+class StyleElement
+{
Where did the following code go?
- if (attr->name() == typeAttr)
- m_type = attr->value().domString().lower();
Again, please don't use underscores:
+ static const AtomicString _default("text/ecmascript");
+ static const AtomicString _xmlspace("xml:space");
+ static const AtomicString _default("all");
r=me
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list