[Webkit-unassigned] [Bug 10640] Auto-generate 10 more Objective-C DOM HTML bindings

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Wed Aug 30 10:45:16 PDT 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=10640


timothy at hatcher.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10317|review?                     |review-
               Flag|                            |




------- Comment #2 from timothy at hatcher.name  2006-08-30 10:45 PDT -------
(From update of attachment 10317)
This looks good. 

One thing:

+                push(@implContent, "    $exceptionInit\n");
+                push(@implContent, "    return $getterContent;\n");
+                push(@implContent, "    $exceptionRaiseOnError\n");

That will never raise on error, since the return happens first. Should
$exceptionRaiseOnError be appended before return?


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list