[Webkit-unassigned] [Bug 10634] -webView:dragDestinationActionMaskForDraggingInfo: is ignored

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10634


macdome at opendarwin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10311|                            |review-
               Flag|                            |




------- Comment #5 from macdome at opendarwin.org  2006-08-29 19:56 PDT -------
(From update of attachment 10311)
A couple nits.

1.  * ChangeLog doesn't need to be in the changelog.  (That often happens when
you run prepare-ChangeLog twice.)

2.  Normally changes require a copyright line.  In this case, since these are <
5 line changes, they probably don't.  But I just thought I should mention it
for the future.

3.  Generally WebKit tries to avoid else statements after returns (as they're
unnecessary.)    _web_dragOperationForDraggingInfo could be written cleaner by
simply returning NSDragOperationCopy inside the if block and returning
NSDragOperationNone outside. Execution only hits the outer return if it didn't
trip the if.

Otherwise looks good.

I think we should do one more round on this patch to fix the nits.  (Since it's
your first patch, it's good to be extra picky.)  But the substance looks fine.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.