[Webkit-unassigned] [Bug 10114] Exceptions thrown by WebKitPlugins are ignored

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10114


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9864|review?                     |review-
               Flag|                            |




------- Comment #13 from darin at apple.com  2006-08-29 13:41 PDT -------
(From update of attachment 9864)
Is there a reason the ExecState function has been changed to no longer be
inlined? I ask because I'm concerned about how the change might affect
performance, and avoiding one extra level of function call in code that is used
in only a few places seems still worthwhile.

Formatting is incorrect in ExecState.cpp: indenting is inconsistent and we
normally indent the initializers rather than putting them flush left.

+    ExecState* execState() { return (m_execState); }

We don't put parentheses around return statements like these.

We'll need to do a performance test to check that this is OK.

Actually I have one big question. What guarantees that the context won't
outlast the execution state? I'm worried that the code in WebScriptObject.mm
might try to set the exception in a deallocated ExecState on the stack.

review- only because of that one last question. The other issues seem to be
minor ones.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.