[Webkit-unassigned] [Bug 4624] WebCore needs autogenerated Obj-C DOM bindings

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=4624


timothy at hatcher.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |timothy at hatcher.name




------- Comment #14 from timothy at hatcher.name  2006-08-24 16:58 PDT -------
This is looking good!

Come comments:

+    # - Add protection against unsupported modules
+    push(@headerContentHeader, "\n#if ${conditional}_SUPPORT\n") if
$conditional;

We don't want to add these XXX_SUPPORT checks to the ObjC headers, since these
are puclic.

On the note about public headers, we need to make sure the generated API is
compatiable with the previous API. This also includes keeping the previous
header names. Those old headers can either contain the @interfaces or include
other new headers that have one class per header. Developers include specific
DOM headers and we need to maintain that build compatibility. We might need a
better way to get these headers copied into WebKit, one shell script per header
in the WebKit project does not scale well if we will have more DOM headers.

+            if ($attribute->signature->extendedAttributes->{"ObjCPrivate"}) {
+                # FIXME: for now, just skip methods not approved for API yet
+                next;
+            }

We really need to generate private headers for the non-public stuff. A lot of
this API is private but still used inside Apple/Safari (if it was private
before autogeneration).

The $headerTemplate needs changed to match the header used in the current
public headers. The current $headerTemplate can used for .m files. 

Some of the methods you labeled as ObjCPrivate are public now, make sure you
sync with the TOT public headers. Such as offsetTop and friends.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.