[Webkit-unassigned] [Bug 10405] REPRO: SVG Maze crashes in RenderPath code

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10405


macdome at opendarwin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10142|review?                     |review-
               Flag|                            |




------- Comment #3 from macdome at opendarwin.org  2006-08-21 08:57 PDT -------
(From update of attachment 10142)
There are a couple things which I would change here.

1.  The test case should ideally draw a green square behind the red one, so
that when the red one is cleared by the javascript, the green square shows
through as an indicator of success.

Second, I 'm not sure I agree with your strokeBoundingBox changes.

IMO it would be cleaner to have a one line if check at the very beginning:
if (isEmpty())
    return CGEmptyRect;

They way you've written it now, it's nondeterministic as to what sort of rect
you are returning.   Also, an if with an early return often reads a bit
cleaner.

Otherwise looks great!

Given that the rect you are returning is non-deterministic (and I'm not sure if
you added your copyright to KCanvasPathQuartz or not) I'm going to have to r-
this.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.